Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Allow multiple entries for BaseUnit= #177

Open
Rampastring opened this issue May 13, 2021 · 2 comments · May be fixed by #1122
Open

[New Feature] Allow multiple entries for BaseUnit= #177

Rampastring opened this issue May 13, 2021 · 2 comments · May be fixed by #1122
Labels
enhancement Enhancement to original behaviour. new-feature New feature or request.
Milestone

Comments

@Rampastring
Copy link
Member

Description:

BaseUnit= only accepts a single entry, which makes it impossible to give different factions different (starting) MCVs without tricky workarounds.

Additional Files:

Kind-of fixed in CnCNet ts-patches: https://github.com/CnCNet/ts-patches/blob/master/src/mods/buildconst_harvesterunit_baseunit.asm

However, as stated in the hack's comments, the hack makes the game replace the unit pointed to by BaseUnit= by a fitting replacement from the HarvesterUnit= list each time the actual base unit is being created. It would be better if BaseUnit= supported a list instead of having this work-around for it.

@Rampastring Rampastring added the new-feature New feature or request. label May 13, 2021
@Rampastring Rampastring added this to the TS-Patches milestone May 13, 2021
@CCHyper
Copy link
Contributor

CCHyper commented May 13, 2021

I would say this is more of a modding bug-fix than a new feature. The programmers expected only one entry in the RULES.INI, so correcting the code to search the vector array just like Red Alert 2 does is the best approach.

@ZivDero
Copy link
Member

ZivDero commented Oct 6, 2024

Resolved in #1073

@ZivDero ZivDero closed this as completed Oct 6, 2024
@ZivDero ZivDero reopened this Oct 28, 2024
@ZivDero ZivDero linked a pull request Oct 28, 2024 that will close this issue
@CCHyper CCHyper removed their assignment Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to original behaviour. new-feature New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants