Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Feature] Add OmniFire to WeaponTypes. #550

Open
tomsons26 opened this issue Sep 14, 2021 · 0 comments · May be fixed by #600
Open

[New Feature] Add OmniFire to WeaponTypes. #550

tomsons26 opened this issue Sep 14, 2021 · 0 comments · May be fixed by #600
Labels
new-feature New feature or request.
Milestone
RA2/YR Features

Comments

@tomsons26
Copy link
Contributor

tomsons26 commented Sep 14, 2021 •
edited by CCHyper
Loading

Description:

OmniFire from RA2.

The unit firing this weapon does not have to turn to face its target before firing.

Possible Implementation:

Patch IsOmniFire check at 00656F99
Replace 0064E59C IsTurretEquipped case with something like

if ( Class->IsTurretEquipped ) {
    WeaponInfoStruct *W = Get_Primary_Weapon();
    if ( TechnoClass::Weapon_Valid(w) && !w->WeaponType->OmniFire ) {
        if ( w->__TurretLocked ) {//not sure what to do with, may be new in YR
            SecondaryFacing.Set_Desired(PrimaryFacing.Current());
        } else {
            SecondaryFacing.Set_Desired(dir);
        }
    }
}
@tomsons26 tomsons26 added the new-feature New feature or request. label Sep 14, 2021
@tomsons26 tomsons26 added this to the RA2/YR Features milestone Sep 14, 2021
@CCHyper CCHyper self-assigned this Sep 27, 2021
@CCHyper CCHyper changed the title [New Feature] Weapon OmniFire [New Feature] Add OmniFire to WeaponTypes. Sep 27, 2021
@CCHyper CCHyper linked a pull request Sep 30, 2021 that will close this issue
Open
@CCHyper CCHyper moved this to In Progress in Vinifera - Initial Release Apr 8, 2022
@CCHyper CCHyper removed their assignment Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new-feature New feature or request.
Projects
Vinifera - Initial Release
Status: In Progress
Milestone
RA2/YR Features
Development

Successfully merging a pull request may close this issue.

Implements OmniFire for WeaponTypes. CCHyper/Vinifera
2 participants
@tomsons26 @CCHyper