Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: False handling of Custom base path #263

Closed
cjunekim opened this issue Jul 20, 2022 · 1 comment
Closed

[Bug]: False handling of Custom base path #263

cjunekim opened this issue Jul 20, 2022 · 1 comment

Comments

@cjunekim
Copy link

Describe the bug

Please have a look at kometenstaub/obsidian-version-history-diff#9 (comment)

Using substring len+1, it omits the first character of the path.

I think it's all coming from using a simple and cheap trick of substring +1 instead of proper path handling. Even something like split by the delimiter(slash or backslash) would've been better.

Relevant errors (if available)

No response

Steps to reproduce

Use custom base path or not, you can see

fatal: ambiguous argument 'xxxxxx': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:

Be careful to see that the file name xxxxx's first character is omitted.

Expected Behavior

No response

Addition context

No response

Operating system

Windows

Plugin version

1.26.3

@Vinzent03
Copy link
Owner

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants