Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't save custom git binary path in repo #283

Closed
DJSchaffner opened this issue Aug 24, 2022 · 2 comments
Closed

Don't save custom git binary path in repo #283

DJSchaffner opened this issue Aug 24, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@DJSchaffner
Copy link

DJSchaffner commented Aug 24, 2022

Hello,

while using Github for synching I just had a situation where I would have found it useful to not save the git binary path in the repository. The reason behind this is that on the computers I use, the git exe file is in different locations and I do not have the necessary rights to change the PATH variable in every of those systems. Every other option would be nice to keep.

While adding this, keeping all the custom paths out of sync would probably be desirable although it's not relevant for me right now.

Maybe as a simple suggestion on on how this could be achieved: Store this path in a seperate file from the other settings so I can add it to the .gitignore file (this way you wouldn't have to change anything about the commit and push process itself)

But feel free to add this in any way you like (If you wish to add this) :)

Until then, I will just have to add the full data.json file to my .gitignore file.

Cheers

@Vinzent03
Copy link
Owner

Oh good point. Will store it in localstorage(if you know that). So you don't even have to ignore a special file.

@Vinzent03 Vinzent03 added the enhancement New feature or request label Aug 24, 2022
@DJSchaffner
Copy link
Author

DJSchaffner commented Aug 24, 2022

Sounds like a good plan. Looking forward to it :)

I do not know where localstorage would be though. Or would that just be a folder within the plugin where you put everything that is supposed to be local only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants