Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Getting file history not working with a custom git name #664

Closed
riabiy opened this issue Dec 31, 2023 · 1 comment
Closed

[Bug]: Getting file history not working with a custom git name #664

riabiy opened this issue Dec 31, 2023 · 1 comment

Comments

@riabiy
Copy link

riabiy commented Dec 31, 2023

Describe the bug

plugin:obsidian-git:34226 Uncaught (in promise) TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))
at getData (plugin:obsidian-git:34226:62)
at async openLineInGitHub (plugin:obsidian-git:34167:16)

if you have anything but git@github.com: it won't work.

Example

personal-git@github.com:...
git@github.com-personal:...

and so on.

Error occurs here

https://github.com/denolehov/obsidian-git/blob/1d81577877ccb548b06fb91036a246aa442a41ae/src/openInGitHub.ts#L84

Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)

No response

Steps to reproduce

Have have anything but git@github.com: in remote

Expected Behavior

No response

Addition context

No response

Operating system

macOS

Installation Method

None

Plugin version

2.22

@Vinzent03
Copy link
Owner

Why would you use personal-git@github.com or anything different from git@github.com This shouldn't be about your local configuration, but about what user is used for the ssh connection to github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants