Skip to content

Conversation

@Nuclei8234
Copy link
Contributor

@Nuclei8234 Nuclei8234 commented Dec 17, 2025

  • Fix Atmos audio tag regex to include ddpa
  • Fix DD+ audio tag regex to support optional 'a' suffix

Summary by CodeRabbit

  • Bug Fixes
    • Improved recognition of Atmos and Dolby Digital Plus audio format variants.

✏️ Tip: You can customize this high-level summary in your review settings.

- Fix Atmos audio tag regex to include ddpa
- Fix DD+ audio tag regex to support optional 'a' suffix
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025

Warning

Rate limit exceeded

@Viren070 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 31 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 80ed92e and 58cdb4d.

📒 Files selected for processing (1)
  • packages/core/src/parser/regex.ts

Walkthrough

The changes extend audio tag regex patterns in the parser to recognise additional format variants. The Atmos pattern now supports "ddpa" with an optional digit suffix, and the DD+ pattern is enhanced to accept an optional "pa" variant after the digital marker.

Changes

Cohort / File(s) Summary
Audio tag regex enhancements
packages/core/src/parser/regex.ts
Updated audioTags regex to support "ddpa" variant for Atmos matching and extended DD+ pattern to recognise optional "pa" suffix after the digital +/plus group

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3–5 minutes

  • Verify regex patterns correctly match intended audio codec variants (Atmos "ddpa" and DD+ "pa")
  • Confirm no unintended pattern matches or overlaps with existing audio tag definitions

Possibly related PRs

Suggested reviewers

  • Viren070

Poem

🐰 Hop, hop, whisper 'ddpa'—
Audio patterns dance anew,
Regex hops where formats play,
Atmos twirls in variants true,
Parser leaps to match the sound!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing audio tag regex patterns for Atmos and DD+.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Viren070 Viren070 merged commit a501b13 into Viren070:main Dec 27, 2025
3 checks passed
@Viren070 Viren070 mentioned this pull request Dec 27, 2025
@Nuclei8234 Nuclei8234 deleted the fix/parser-regex-patterns branch January 3, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants