Skip to content

winget-releaser failure during Update Windows packages step: RequestError [HttpError]: other side closed #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gedochao opened this issue Jan 17, 2024 · 4 comments · Fixed by #2991
Labels
bug Something isn't working internal Internal or build-related changes releasing Issues tied to the Scala CLI release pipeline windows Windows-specific issues

Comments

@Gedochao
Copy link
Contributor

Version(s)
happens since the 1.1.1 release

Describe the bug
We are getting RequestError [HttpError] when releasing Scala CLI on winget with the winget-releaser action.

RequestError [HttpError]: other side closed
    at D:\a\_actions\vedantmgoyal2009\winget-releaser\v2\dist\index.js:6964:11
    at async D:\a\_actions\vedantmgoyal2009\winget-releaser\v2\dist\index.js:30094:27 {
  status: 500,
  request: {
    method: 'GET',
    url: 'https://api.github.com/repos/microsoft/winget-pkgs/contents/manifests%2Fv%2FVirtusLab%2FScalaCLI',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit-core.js/5.0.1 Node.js/20.8.1 (win32; x64)',
      authorization: 'token [REDACTED]'
    },
    request: {
      agent: Agent {
        _events: [Object: null prototype] {
          free: [Function (anonymous)],
          newListener: [Function: maybeEnableKeylog]
        },
        _eventsCount: 2,
        _maxListeners: undefined,
        defaultPort: 443,
        protocol: 'https:',
        options: [Object: null prototype] {
          keepAlive: true,
          scheduling: 'lifo',
          timeout: 5000,
          noDelay: true,
          path: null
        },
        requests: [Object: null prototype] {},
        sockets: [Object: null prototype] {},
        freeSockets: [Object: null prototype] {},
        keepAliveMsecs: 1000,
        keepAlive: true,
        maxSockets: Infinity,
        maxFreeSockets: 256,
        scheduling: 'lifo',
        maxTotalSockets: Infinity,
        totalSocketCount: 0,
        maxCachedSessions: 100,
        _sessionCache: { map: {}, list: [] },
        [Symbol(kCapture)]: false
      },
      fetch: [Function: proxyFetch],
      hook: [Function: bound bound register]
    }
  }
}

The error seems to be a false positive, as the relevant winget-pckgs PR is being created correctly and the update seems to work, otherwise.

Fortunately, it is the last step, so no important actions are aborted because of this failure.

To Reproduce
Seems to happen on every Scala CLI release now. Just check the Update Windows packages step at the end of the release.

Expected behaviour
When releasing Scala CLI, we shouldn't have false-positive errors.

Extra context

@Gedochao Gedochao added bug Something isn't working windows Windows-specific issues internal Internal or build-related changes releasing Issues tied to the Scala CLI release pipeline labels Jan 17, 2024
@Gedochao Gedochao changed the title False-positive winget-releaser failures during Update Windows packages step winget-releaser failure during Update Windows packages step: RequestError [HttpError]: other side closed Jan 24, 2024
@Gedochao
Copy link
Contributor Author

Created a corresponding bug ticket on winget-releaser:

@Gedochao
Copy link
Contributor Author

Gedochao commented Mar 7, 2024

Interestingly, this did not occur with v1.2.0.
The PR seemingly got created without any errors:

If no no problems return with v1.2.1, I will close this ticket.

@Gedochao
Copy link
Contributor Author

Gedochao commented Apr 3, 2024

The issue did not return in v1.2.1.
Closing this.

@Gedochao Gedochao closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2024
@Gedochao Gedochao reopened this Apr 26, 2024
@Gedochao
Copy link
Contributor Author

Gedochao commented Apr 26, 2024

The problem came back in 1.3.0:
https://github.com/VirtusLab/scala-cli/actions/runs/8844623239/job/24290002815#step:6:102

RequestError [HttpError]: read ECONNRESET
    at D:\a\_actions\vedantmgoyal2009\winget-releaser\v2\dist\index.js:6964:11
    at async D:\a\_actions\vedantmgoyal2009\winget-releaser\v2\dist\index.js:30094:27 {
  status: 500,
  request: {
    method: 'GET',
    url: 'https://api.github.com/repos/microsoft/winget-pkgs/contents/manifests%2Fv%2FVirtusLab%2FScalaCLI',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit-core.js/5.0.1 Node.js/20.8.1 (win32; x64)',
      authorization: 'token [REDACTED]'
    },
    request: {
      agent: Agent {
        _events: [Object: null prototype] {
          free: [Function (anonymous)],
          newListener: [Function: maybeEnableKeylog]
        },
        _eventsCount: 2,
        _maxListeners: undefined,
        defaultPort: 443,
        protocol: 'https:',
        options: [Object: null prototype] {
          keepAlive: true,
          scheduling: 'lifo',
          timeout: 5000,
          noDelay: true,
          path: null
        },
        requests: [Object: null prototype] {},
        sockets: [Object: null prototype] {},
        freeSockets: [Object: null prototype] {},
        keepAliveMsecs: [100](https://github.com/VirtusLab/scala-cli/actions/runs/8844623239/job/24290002815#step:6:103)0,
        keepAlive: true,
        maxSockets: Infinity,
        maxFreeSockets: 256,
        scheduling: 'lifo',
        maxTotalSockets: Infinity,
        totalSocketCount: 0,
        maxCachedSessions: 100,
        _sessionCache: { map: {}, list: [] },
        [Symbol(kCapture)]: false
      },
      fetch: [Function: proxyFetch],
      hook: [Function: bound bound register]
    }
  }
}

Seems likely this is intermittent and we should expect it popping up randomly on releases.
Relevant PR got created:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Internal or build-related changes releasing Issues tied to the Scala CLI release pipeline windows Windows-specific issues
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant