Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixelmatch could not find background color diff #400

Open
utkukilincci opened this issue May 29, 2023 · 10 comments
Open

Pixelmatch could not find background color diff #400

utkukilincci opened this issue May 29, 2023 · 10 comments
Labels

Comments

@utkukilincci
Copy link

utkukilincci commented May 29, 2023

Here is our comparison

Screenshot 2023-05-29 at 17 22 41

you can find the images links below

https://cdn.dsmcdn.com/seller-ads/vrt/1685367692161.screenshot.png
https://cdn.dsmcdn.com/seller-ads/vrt/1685100884772.baseline.png

@pashidlos
Copy link
Member

@utkukilincci could you share what image comparison algorithm is used and it's settings in project details on main page?

@pashidlos pashidlos added bug Something isn't working api waiting additional date from user is requested labels May 30, 2023
@utkukilincci
Copy link
Author

@utkukilincci could you share what image comparison algorithm is used and it's settings in project details on main page?

here is

Screenshot 2023-05-30 at 17 46 12

@wintero92
Copy link

Any updates on this?

@utkukilincci
Copy link
Author

Any updates on this ?

@wintero92
Copy link

wintero92 commented Jul 26, 2023

In any case, the text pixel diff threshold is not the default value of diff tolerance -- the one with the typo -- but internal pixelmatch configuration that takes into account the distance measure of two given colors in given pixel under test.

It works like this:

  • pixel diff threshold, i.e., threshold config for pixelmatch, pixelmatch will compare pixel by pixel measuring the colors, if you set threshold closer to the zero it will be more strict when it comes to the distance of the colors
  • diff tolerance on vrt level which just allows number of different pixels returned by pixelmatch in percentile.

FYI: @utkukilincci

@utkukilincci
Copy link
Author

so, what should I do?

@pashidlos
Copy link
Member

@utkukilincci comparison is made by pixelmatch library
online demo with your images doesn't spot the diff either https://codepen.io/qgustavor/pen/pLbJvy
there is similar issue and basically nothing I could help with unless library is able to spot the diff mapbox/pixelmatch#127

you could try switching to lookSame library in config

@wintero92
Copy link

Or set the threshold for pixel match to lower number or even to zero, like I described above.

@pashidlos
Copy link
Member

pashidlos commented Jul 26, 2023

@wintero92 changing threshold wont help
here is example with 0.05
image
and 0
image

@pashidlos pashidlos removed bug Something isn't working waiting additional date from user is requested labels Jul 26, 2023
@pashidlos pashidlos changed the title Why VRT could not find background color diff ? Pixelmatch could not find background color diff Jul 26, 2023
@wintero92
Copy link

And zero?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants