You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem:
Some of the tests could be rewritten better. Currently some are parameterized and others aren't. We also are capturing errors without specifying what errors we're supposed to be capturing.
Solution:
Go through and state what errors are thrown for which tests
Parameterize the tests that need it (Like modulus)
Considerations:
The errors may change in the future when we do better error handling that's more human friendly.
The text was updated successfully, but these errors were encountered:
One thing that I'm not doing that I probably should is ensure that the dice roll history is still there and that they're being appended correctly.
What I mean by that is the history of the entire dice string parsing should have the dice rolls be reflected in the EvaluationResults in the correct order. I am unsure if that means that all of the left-hand rolls go before or after the right-hand when doing operations or if it's the case that they need to be interleaved in some way. The latter would be difficult to do, as we would have to have some way of figuring out which actually came first. Whether that means that they need to have a timestamp or a counter attached to them, I'm not sure.
Problem:
Some of the tests could be rewritten better. Currently some are parameterized and others aren't. We also are capturing errors without specifying what errors we're supposed to be capturing.
Solution:
Considerations:
The text was updated successfully, but these errors were encountered: