Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piapro embeds do not work anymore #1377

Closed
andreoda opened this issue Apr 26, 2023 · 1 comment · Fixed by #1465
Closed

Piapro embeds do not work anymore #1377

andreoda opened this issue Apr 26, 2023 · 1 comment · Fixed by #1465
Labels
bug/error Bugs and errors (timeout) content: songs Song entries media Media playback (embeds) priority: high Issues/Tasks that should be done ASAP

Comments

@andreoda
Copy link
Member

Website

VocaDB

Describe the bug

The "Piapro" embeds on song entries etc. do not function anymore.

To Reproduce

Steps to reproduce the behavior:

  1. Go to "https://vocadb.net/S/1363"
  2. Click on the original media "Piapro" link
  3. See the embed not displaying correctly

Expected behavior

Normally, a mini player would appear (Piapro player).

Screenshots

Result when trying to play a "Piapro" embed:
grafik

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Firefox
@andreoda andreoda added media Media playback (embeds) content: songs Song entries bug/error Bugs and errors (timeout) labels Apr 26, 2023
@andreoda andreoda changed the title Piapro embeds not working anymore Piapro embeds do not work anymore Apr 26, 2023
@FinnRG FinnRG moved this to Todo - Bugs in Frontend overhaul May 3, 2023
@FinnRG
Copy link
Member

FinnRG commented May 6, 2023

This change was made in this commit 9d91044.

@andreoda andreoda added the priority: high Issues/Tasks that should be done ASAP label May 15, 2023
@VocaDB VocaDB deleted a comment from FinnRG May 23, 2023
@VocaDB VocaDB deleted a comment from szc126 May 23, 2023
@VocaDB VocaDB deleted a comment from FinnRG May 23, 2023
This was referenced May 23, 2023
Open
Merged
@github-project-automation github-project-automation bot moved this from Todo - Bugs to Done in Frontend overhaul May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/error Bugs and errors (timeout) content: songs Song entries media Media playback (embeds) priority: high Issues/Tasks that should be done ASAP
Projects
Bugs, errors, other non-functioning things
Status: Done
Frontend overhaul
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use html5 iframes for piapro embeds FinnRG/vocadb
2 participants
@andreoda @FinnRG