Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher on props doesn't react on deep changes #11

Open
gaperton opened this issue Apr 12, 2018 · 0 comments
Open

Watcher on props doesn't react on deep changes #11

gaperton opened this issue Apr 12, 2018 · 0 comments
Labels

Comments

@gaperton
Copy link

gaperton commented Apr 12, 2018

  • Props watchers must use the same mechanics as pureRender to detect props changes.
  • state and store updates must not trigger UI updates when made from the props watcher.
  • Watchers must rely on new React lifecycle hooks.
static props = {
    items : Collection.has.watcher( 'onItemsChange' )
}

The watcher is called if the new instance of items being passed, but not when something was changed inside.

@gaperton gaperton added the bug label Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant