Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading external scripts for pages with Monaco Editor #232

Closed
asimonok opened this issue Nov 13, 2023 · 1 comment · Fixed by #312
Closed

Fix loading external scripts for pages with Monaco Editor #232

asimonok opened this issue Nov 13, 2023 · 1 comment · Fixed by #312
Assignees
@asimonok
Labels
grafana Grafana issue

Comments

@asimonok
Copy link
Collaborator

asimonok commented Nov 13, 2023 •
edited
Loading

Currently, External resources don't work for pages which have Monaco Editor (e.g. edit panel).

Depends on grafana/grafana#78415
@asimonok asimonok self-assigned this Nov 13, 2023
@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 20, 2023
@mikhail-vl mikhail-vl added this to the Version 4.2.0 milestone Nov 20, 2023
@asimonok asimonok changed the title Fix panel editing with external resources Fix loading external scripts for pages with Monaco Editor Nov 20, 2023
@mikhail-vl mikhail-vl added question Further information is requested and removed enhancement New feature or request labels Nov 20, 2023
@mikhail-vl mikhail-vl removed this from the Version 4.2.0 milestone Nov 20, 2023
@mikhail-vl mikhail-vl added the grafana Grafana issue label Nov 21, 2023
@asimonok
Copy link
Collaborator Author

Based on answer - grafana/grafana#78415 (comment)

We can't load external scripts in global context so we have to find a way to load them with local context

@asimonok asimonok removed the grafana Grafana issue label Nov 22, 2023
@mikhail-vl mikhail-vl added grafana Grafana issue and removed question Further information is requested labels Dec 25, 2023
@asimonok asimonok mentioned this issue Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asimonok asimonok

Labels
grafana Grafana issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ES6 Modules Support VolkovLabs/business-text
2 participants
@asimonok @mikhail-vl