Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings for typescript #22

Open
k0pernikus opened this issue Jul 31, 2017 · 1 comment
Open

Add typings for typescript #22

k0pernikus opened this issue Jul 31, 2017 · 1 comment

Comments

@k0pernikus
Copy link

k0pernikus commented Jul 31, 2017

Are there any plans to add typescript typings to DefinitelyTyped for this lib?

I am currently investigating the use case for voltdb and since we are using nodejs / typescript, having a typed library would be a huge help.

@benjaminballard
Copy link
Contributor

Not currently, but this is a good idea. We're very open to community contributions if this is something you'd like to add to the library. You'd need to sign a CLA first. I think it would be great to add typescript support. We just recently updated this library to support a current version of javascript, but there are things like this that make sense to make it more up to date with current nodejs practices.

Currently, this is about all we have to say about data types, which are not javascript types: https://github.com/VoltDB/voltdb-client-nodejs#data-types

I believe the driver just uses javascript number and string types, and the API lets you declare the corresponding VoltDB datatype of parameters, or get the datatypes from query results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants