Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf 5.28.0 #503

Closed
tnoczyns-volue opened this issue Aug 29, 2024 · 2 comments · Fixed by #504
Closed

Protobuf 5.28.0 #503

tnoczyns-volue opened this issue Aug 29, 2024 · 2 comments · Fixed by #504

Comments

@tnoczyns-volue
Copy link
Collaborator

With new protobuf 5.28.0 released 28th of August there are 2 issues:

  • We observe warnings like:
Lib\site-packages\google\protobuf\runtime_version.py:112: UserWarning: Protobuf gencode version 5.27.2 is older than the runtime version 5.28.0 at volue/mesh/proto/auth/v1alpha/auth.proto. Please avoid checked-in Protobuf gencode that can be obsolete.

We are using grpcio tools to compile our proto files. It seems regardless of the installed protobuf version, grpcio tools generate them using version 5.27.2.

  • This discrepancy may be the potential cause of one test failing: test_get_utc_time_attribute[True].
@tnoczyns-volue
Copy link
Collaborator Author

Lib\site-packages\google\protobuf\runtime_version.py:112: UserWarning: Protobuf gencode version 5.27.2 is older than the runtime version 5.28.0 at volue/mesh/proto/auth/v1alpha/auth.proto. Please avoid checked-in Protobuf gencode that can be obsolete.
  • The reason why test started failing: With protobuf 5.28.0 the approach with listing fields to distinguish whether a singular field was set or not seems to no longer work: all fields are listed, for previous version 5.27.4 only the ones where actual, non-empty value was provided. It may be because of the codegen vs runtime difference.

@tnoczyns-volue
Copy link
Collaborator Author

For the first issue:

With new protobuf 5.28.0 released 28th of August there are 2 issues:

  • We observe warnings like:
Lib\site-packages\google\protobuf\runtime_version.py:112: UserWarning: Protobuf gencode version 5.27.2 is older than the runtime version 5.28.0 at volue/mesh/proto/auth/v1alpha/auth.proto. Please avoid checked-in Protobuf gencode that can be obsolete.

See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant