Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URGENT: Update Compass to emit the event nonce for Testnet and Mainnet Proposal 11/14 #996

Closed
verabehr opened this issue Nov 14, 2023 · 2 comments · Fixed by palomachain/compass-evm#26
Assignees
Labels

Comments

@verabehr
Copy link

verabehr commented Nov 14, 2023

At the moment, gravity events emitted from the contract have the following signature:

  • SendToPalomaEvent(address,address,string,uint256)
  • BatchSendEvent(address,uint256)

It's necessary that all events observed by Pigeons contain an event nonce, that is continuously increased with every event emitted by the contract.

At the moment, the uint256 field of the BatchSendEvent() only emits the batch nonce that was used when calling it, so it's signature would need to look like this: BatchSendEvent(address,batchNonce,eventNonce) instead.

I do not know what the uint256 field of the SendToPalomaEvent emits at the moment.

But the event nonce should be included in all events emitted, and shared across every event.

@taariq taariq changed the title Update Compass to emit the event nonce URGENT: Update Compass to emit the event nonce for Testnet and Mainnet Proposal 11/14 Nov 14, 2023
@verabehr
Copy link
Author

Here is an example of SendToPaloma event on bnb for reference as well https://bscscan.com/tx/0xedbdabffd33f56e550d2d6aa1787913d8810f6ef589696257afa360b278df016#eventlog

@byte-bandit
Copy link

@webelf101

Because we already have validators with populated data for event nonces, we'd need to event to start emitting nonces from 100'000 instead of 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants