Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: labstack/echo-contrib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Volumental/echo-contrib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 9 commits
  • 3 files changed
  • 2 contributors

Commits on Apr 21, 2021

  1. CreateChildSpan: use context.Context instead of echo.Context.

    Daniel Llatas Spiers committed Apr 21, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    ad0a5bf View commit details

  2. deps: import context package.

    Daniel Llatas Spiers committed Apr 21, 2021
    Copy the full SHA
    349cf6a View commit details

  3. Merge pull request #1 from Volumental/tech/change-interface 

    CreateChildSpan: use context.Context instead of echo.Context.
    Daniel Llatas Spiers authored Apr 21, 2021
    Copy the full SHA
    39293cc View commit details

  4. mod: update package to point to Volumental fork.

    Daniel Llatas Spiers committed Apr 21, 2021
    Copy the full SHA
    9c7d110 View commit details

  5. Merge pull request #2 from Volumental/tech/change-interface 

    Update package name in go.mod
    Daniel Llatas Spiers authored Apr 21, 2021
    Copy the full SHA
    5df32c2 View commit details

Commits on Nov 8, 2022

  1. Add catalog-info.yaml config file

    @dllatas
    dllatas committed Nov 8, 2022
    Copy the full SHA
    ac44340 View commit details

  2. Merge pull request #3 from Volumental/backstage-integration 

    Add catalog-info.yaml config file
    @dllatas
    dllatas authored Nov 8, 2022
    Copy the full SHA
    145812c View commit details

Commits on Nov 9, 2022

  1. Update catalog-info.yaml

    @dllatas
    dllatas authored Nov 9, 2022
    Copy the full SHA
    2c2e35a View commit details

Commits on Nov 18, 2022

  1. Update catalog-info.yaml

    Daniel Llatas Spiers authored Nov 18, 2022
    Copy the full SHA
    3c8f957 View commit details
Showing with 18 additions and 3 deletions.
  1. +14 −0 catalog-info.yaml
  2. +1 −1 go.mod
  3. +3 −2 jaegertracing/jaegertracing.go
14 changes: 14 additions & 0 deletions catalog-info.yaml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
apiVersion: backstage.io/v1alpha1
kind: Component
metadata:
name: echo-contrib
title: Echo contribution
description: Echo community contribution
annotations:
github.com/project-slug: Volumental/echo-contrib
tags:
- go
spec:
type: library
lifecycle: production
owner: infrastructure
2 changes: 1 addition & 1 deletion go.mod
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/labstack/echo-contrib
module github.com/Volumental/echo-contrib

require (
github.com/appleboy/gofight/v2 v2.1.2
5 changes: 3 additions & 2 deletions jaegertracing/jaegertracing.go
View file
Original file line number Diff line number Diff line change
@@ -22,6 +22,7 @@ package jaegertracing

import (
"bytes"
"context"
"fmt"
"io"
"io/ioutil"
@@ -217,8 +218,8 @@ func TraceFunction(ctx echo.Context, fn interface{}, params ...interface{}) (res

// CreateChildSpan creates a new opentracing span adding tags for the span name and caller details.
// User must call defer `sp.Finish()`
func CreateChildSpan(ctx echo.Context, name string) opentracing.Span {
parentSpan := opentracing.SpanFromContext(ctx.Request().Context())
func CreateChildSpan(ctx context.Context, name string) opentracing.Span {
parentSpan := opentracing.SpanFromContext(ctx)
sp := opentracing.StartSpan(
name,
opentracing.ChildOf(parentSpan.Context()))