feat(nav-item, nav-disclosure): add ghost-light appearance (VIV-1466) #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1512 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 322 +199
Lines 1562 5416 +3854
Branches 108 667 +559
===========================================
+ Hits 1562 5416 +3854
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ghost-light � Conflicts: � libs/components/src/lib/appearance-ui/appearance-ui.scss � libs/components/src/lib/nav-disclosure/nav-disclosure.scss � libs/components/src/lib/nav-item/nav-item.scss
…ghost-light � Conflicts: � docs/design/appearance.md � libs/components/src/lib/appearance-ui/appearance-ui.ts � libs/components/src/lib/enums.ts
rachelbt
changed the title
TaylorJ76
previously approved these changes
Apr 15, 2024
TaylorJ76
approved these changes
Apr 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder if this needs to be the only appearance or the default one.
Why yes - will fix un-seen states where theres bg to the nav
Why not - we have generated css-variables that will not be in use anymore if someone is using them.
WDYT?