Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(banner): warning connotation when removable (VIV-1431) #1647

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Mar 26, 2024

No description provided.

@rinaok rinaok changed the title fix(banner): warning connotation when removable fix(banner): warning connotation when removable (VIV-1431) Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (c876dab).
Report is 876 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1647     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       320    +197     
  Lines         1562      5375   +3813     
  Branches       108       652    +544     
===========================================
+ Hits          1562      5375   +3813     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rachelbt rachelbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Not sure why there are new png - there's no change there :)

@rinaok rinaok merged commit 8fe6bab into main Mar 27, 2024
16 checks passed
@rinaok rinaok deleted the VIV-1431-button-warning-connotation branch March 27, 2024 10:00
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants