feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) #1789

RichardHelm · 2024-06-21T16:56:13Z

Determine which props will be passed as attribute and which as DOM prop and consistently pass this way for both Vue 2 and 3.
Exceptions added for value attributes to be passed by their DOM prop name.
E.g. value prop will now be forwarded to current-value attribute.

codecov · 2024-06-21T17:05:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (90092c6) to head (0274e9f).

❗ Current head 0274e9f differs from pull request most recent head cc0154d

Please upload reports for the commit cc0154d to get more accurate results.

Additional details and impacted files

@@               Coverage Diff                @@
##           main-4.0.0-RC1     #1789   +/-   ##
================================================
  Coverage          100.00%   100.00%           
================================================
  Files                 337       337           
  Lines                5925      5923    -2     
  Branches              748       744    -4     
================================================
- Hits                 5925      5923    -2

Flag	Coverage Δ
unittests	`100.00% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* feat(tooltip)!: sets default max width (VIV-1799) (#1798) * chore: updates docs --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> * feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793) * Make PR CI start on any main branch * feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803) * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789) * Improve error messages * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) --------- Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com> * chore(docs): v4 migration page (VIV-1801) (#1796) * fix(tabs)!: change gutters default to small (VIV-1796) (#1804) * chore(docs)!: refine docs for v-4 (VIV-000) (#1813) * feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814) --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com> Co-authored-by: Yonatan Kra <me@yonatankra.com> Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com> Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* feat(tooltip)!: sets default max width (VIV-1799) (#1798) * chore: updates docs * feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793) * Make PR CI start on any main branch * feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803) * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789) * Improve error messages * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) * chore(docs): v4 migration page (VIV-1801) (#1796) * fix(tabs)!: change gutters default to small (VIV-1796) (#1804) * chore(docs)!: refine docs for v-4 (VIV-000) (#1813) * feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)

* feat(tooltip): sets default max width (VIV-1799) (#1798) * chore: updates docs --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> * feat(data-grid-cell): change default value of block-size and white-space (VIV-1797) (#1793) * Make PR CI start on any main branch * feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803) * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789) * Improve error messages * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) --------- Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com> * chore(docs): v4 migration page (VIV-1801) (#1796) * fix(tabs)!: change gutters default to small (VIV-1796) (#1804) * chore(docs)!: refine docs for v-4 (VIV-000) (#1813) * feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814) --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com> Co-authored-by: Yonatan Kra <me@yonatankra.com> Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com> Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* feat(tooltip)!: sets default max width (VIV-1799) (#1798) * chore: updates docs --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> * feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793) * Make PR CI start on any main branch * feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803) * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789) * Improve error messages * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) --------- Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com> * chore(docs): v4 migration page (VIV-1801) (#1796) * fix(tabs)!: change gutters default to small (VIV-1796) (#1804) * chore(docs)!: refine docs for v-4 (VIV-000) (#1813) * feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814) * attempt at RP --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com> Co-authored-by: Yonatan Kra <me@yonatankra.com> Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com> Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* feat(tooltip): sets default max width (VIV-1799) (#1798) * chore: updates docs --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> * feat(data-grid-cell): change default value of block-size and white-space (VIV-1797) (#1793) * Make PR CI start on any main branch * feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803) * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789) * Improve error messages * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) --------- Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com> * chore(docs): v4 migration page (VIV-1801) (#1796) * fix(tabs)!: change gutters default to small (VIV-1796) (#1804) * chore(docs)!: refine docs for v-4 (VIV-000) (#1813) * feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814) * attempt at RP --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com> Co-authored-by: Yonatan Kra <me@yonatankra.com> Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com> Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* feat(tooltip): sets default max width (VIV-1799) (#1798) * chore: updates docs --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> * feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793) * Make PR CI start on any main branch * feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803) * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789) * Improve error messages * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) --------- Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com> * chore(docs): v4 migration page (VIV-1801) (#1796) * fix(tabs)!: change gutters default to small (VIV-1796) (#1804) * chore(docs)!: refine docs for v-4 (VIV-000) (#1813) * feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814) * attempt at RP --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com> Co-authored-by: Yonatan Kra <me@yonatankra.com> Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com> Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

feat(tooltip)!: sets default max width (VIV-1799) (#1798) * chore: updates docs --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> * feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793) * Make PR CI start on any main branch * feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803) * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789) * Improve error messages * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) --------- Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com> * chore(docs): v4 migration page (VIV-1801) (#1796) * fix(tabs)!: change gutters default to small (VIV-1796) (#1804) * chore(docs)!: refine docs for v-4 (VIV-000) (#1813) * feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814) * attempt at RP --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com> Co-authored-by: Yonatan Kra <me@yonatankra.com> Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com> Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

feat(tooltip): sets default max width (VIV-1799) (#1798) * chore: updates docs --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> feat(data-grid-cell): change default value of block-size and white-space (VIV-1797) (#1793) * Make PR CI start on any main branch * feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803) * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789) * Improve error messages * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) --------- Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com> * chore(docs): v4 migration page (VIV-1801) (#1796) * fix(tabs)!: change gutters default to small (VIV-1796) (#1804) * chore(docs)!: refine docs for v-4 (VIV-000) (#1813) * feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814) * attempt at RP --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com> Co-authored-by: Yonatan Kra <me@yonatankra.com> Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com> Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

feat(tooltip)!: sets default max width (VIV-1799) (#1798) feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793) feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803) feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789) feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) chore(docs): v4 migration page (VIV-1801) (#1796) fix(tabs)!: change gutters default to small (VIV-1796) (#1804) chore(docs)!: refine docs for v-4 (VIV-000) (#1813) feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)

* feat(tooltip)!: sets default max width (VIV-1799) (#1798) * chore: updates docs * feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793) * Make PR CI start on any main branch * feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803) * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789) * Improve error messages * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) * chore(docs): v4 migration page (VIV-1801) (#1796) * fix(tabs)!: change gutters default to small (VIV-1796) (#1804) * chore(docs)!: refine docs for v-4 (VIV-000) (#1813) * feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814) * attempt at RP --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com> Co-authored-by: Yonatan Kra <me@yonatankra.com> Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com> Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* feat(tooltip)!: sets default max width (VIV-1799) (#1798) * chore: updates docs --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> * feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793) * Make PR CI start on any main branch * feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803) * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789) * Improve error messages * feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) --------- Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com> * chore(docs): v4 migration page (VIV-1801) (#1796) * fix(tabs)!: change gutters default to small (VIV-1796) (#1804) * chore(docs)!: refine docs for v-4 (VIV-000) (#1813) * feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814) * attempt at RP --------- Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home> Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com> Co-authored-by: Yonatan Kra <me@yonatankra.com> Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com> Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

RichardHelm added the Breaking Change Changes that will go into the next major version label Jun 21, 2024

deno-deploy bot deployed to Preview June 21, 2024 17:01 View deployment

RichardHelm changed the base branch from main to main-4.0.0-RC1 June 26, 2024 08:52

RichardHelm added 2 commits June 26, 2024 09:52

Improve error messages

3a08811

feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

2218cd5

RichardHelm force-pushed the VIV-1798-wrappers-value-props branch from 3b42576 to 2218cd5 Compare June 26, 2024 08:52

Merge branch 'main-4.0.0-RC1' into VIV-1798-wrappers-value-props

0274e9f

deno-deploy bot deployed to Preview June 27, 2024 07:28 View deployment

TaylorJ76 approved these changes Jun 27, 2024

View reviewed changes

Merge branch 'main-4.0.0-RC1' into VIV-1798-wrappers-value-props

cc0154d

deno-deploy bot deployed to Preview June 27, 2024 09:42 View deployment

RichardHelm merged commit fdfcc67 into main-4.0.0-RC1 Jun 27, 2024
11 checks passed

RichardHelm deleted the VIV-1798-wrappers-value-props branch June 27, 2024 10:56

github-actions bot mentioned this pull request Jul 1, 2024

chore: release main #1829

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) #1789

feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) #1789

RichardHelm commented Jun 21, 2024

codecov bot commented Jun 21, 2024 •

edited

Loading

feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) #1789

feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) #1789

Conversation

RichardHelm commented Jun 21, 2024

codecov bot commented Jun 21, 2024 • edited Loading

Codecov Report

codecov bot commented Jun 21, 2024 •

edited

Loading