Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) #1793

Merged
merged 1 commit into from
Jun 26, 2024
Merged

feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) #1793

merged 1 commit into from
Jun 26, 2024

Conversation

RichardHelm
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jun 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8b937ee) to head (78b2b34).

❗ Current head 78b2b34 differs from pull request most recent head 53be517

Please upload reports for the commit 53be517 to get more accurate results.

Additional details and impacted files 
@@               Coverage Diff                @@
##           main-4.0.0-RC1     #1793   +/-   ##
================================================
  Coverage          100.00%   100.00%           
================================================
  Files                 337       337           
  Lines                5925      5924    -1     
  Branches              747       747           
================================================
- Hits                 5925      5924    -1
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rachelbt rachelbt added the Breaking Change Changes that will go into the next major version label Jun 25, 2024
@rachelbt rachelbt self-requested a review June 26, 2024 08:45
@RichardHelm RichardHelm changed the base branch from main to main-4.0.0-RC1 June 26, 2024 08:51
@RichardHelm RichardHelm force-pushed the VIV-1797-datagrid-row-height branch from 78b2b34 to 53be517 Compare June 26, 2024 08:51
rachelbt
rachelbt approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@rachelbt rachelbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
LGTM

@RichardHelm RichardHelm merged commit 790142c into main-4.0.0-RC1 Jun 26, 2024
3 checks passed
@RichardHelm RichardHelm deleted the VIV-1797-datagrid-row-height branch June 26, 2024 10:34
YonatanKra added a commit that referenced this pull request Jul 1, 2024
@YonatanKra @RichardHelm
@rachelbt @TaylorJ76
feat(components)!: vivid 4.0.0 release (VIV-1795) (#1802)
77efe79 
* feat(tooltip)!: sets default max width (VIV-1799) (#1798)

* chore: updates docs

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>

* feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793)

* Make PR CI start on any main branch

* feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803)

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789)

* Improve error messages

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

---------

Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* chore(docs): v4 migration page (VIV-1801) (#1796)

* fix(tabs)!: change gutters default to small (VIV-1796) (#1804)

* chore(docs)!: refine docs for v-4 (VIV-000) (#1813)

* feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>
Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com>
Co-authored-by: Yonatan Kra <me@yonatankra.com>
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>
YonatanKra added a commit that referenced this pull request Jul 1, 2024
@YonatanKra
vMain 4.0.0 rc2 (#1818)
e584455 
* feat(tooltip)!: sets default max width (VIV-1799) (#1798)

* chore: updates docs

* feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793)

* Make PR CI start on any main branch

* feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803)

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789)

* Improve error messages

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

* chore(docs): v4 migration page (VIV-1801) (#1796)

* fix(tabs)!: change gutters default to small (VIV-1796) (#1804)

* chore(docs)!: refine docs for v-4 (VIV-000) (#1813)

* feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)
YonatanKra added a commit that referenced this pull request Jul 1, 2024
@YonatanKra @RichardHelm
@rachelbt @TaylorJ76
feat(vivid)!: release v4 (VIV-795)
fe15afc 
* feat(tooltip): sets default max width (VIV-1799) (#1798)

* chore: updates docs

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>

* feat(data-grid-cell): change default value of block-size and white-space (VIV-1797) (#1793)

* Make PR CI start on any main branch

* feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803)

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789)

* Improve error messages

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

---------

Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* chore(docs): v4 migration page (VIV-1801) (#1796)

* fix(tabs)!: change gutters default to small (VIV-1796) (#1804)

* chore(docs)!: refine docs for v-4 (VIV-000) (#1813)

* feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>
Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com>
Co-authored-by: Yonatan Kra <me@yonatankra.com>
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>
YonatanKra added a commit that referenced this pull request Jul 1, 2024
@YonatanKra @RichardHelm
@rachelbt @TaylorJ76
chore(vivid): V4 release (VIV-000) (#1820)
fd7cf2d 
* feat(tooltip)!: sets default max width (VIV-1799) (#1798)

* chore: updates docs

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>

* feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793)

* Make PR CI start on any main branch

* feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803)

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789)

* Improve error messages

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

---------

Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* chore(docs): v4 migration page (VIV-1801) (#1796)

* fix(tabs)!: change gutters default to small (VIV-1796) (#1804)

* chore(docs)!: refine docs for v-4 (VIV-000) (#1813)

* feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)

* attempt at RP

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>
Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com>
Co-authored-by: Yonatan Kra <me@yonatankra.com>
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>
YonatanKra added a commit that referenced this pull request Jul 1, 2024
@YonatanKra @RichardHelm
@rachelbt @TaylorJ76
chore(vivid)!: v4 release (VIV-000) (#1821)
5e5ad50 
* feat(tooltip): sets default max width (VIV-1799) (#1798)

* chore: updates docs

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>

* feat(data-grid-cell): change default value of block-size and white-space (VIV-1797) (#1793)

* Make PR CI start on any main branch

* feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803)

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789)

* Improve error messages

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

---------

Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* chore(docs): v4 migration page (VIV-1801) (#1796)

* fix(tabs)!: change gutters default to small (VIV-1796) (#1804)

* chore(docs)!: refine docs for v-4 (VIV-000) (#1813)

* feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)

* attempt at RP

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>
Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com>
Co-authored-by: Yonatan Kra <me@yonatankra.com>
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>
YonatanKra added a commit that referenced this pull request Jul 1, 2024
@YonatanKra @RichardHelm
@rachelbt @TaylorJ76
feat(vivid): attempt at releasing (#1823)
958ef90 
* feat(tooltip): sets default max width (VIV-1799) (#1798)

* chore: updates docs

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>

* feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793)

* Make PR CI start on any main branch

* feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803)

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789)

* Improve error messages

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

---------

Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* chore(docs): v4 migration page (VIV-1801) (#1796)

* fix(tabs)!: change gutters default to small (VIV-1796) (#1804)

* chore(docs)!: refine docs for v-4 (VIV-000) (#1813)

* feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)

* attempt at RP

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>
Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com>
Co-authored-by: Yonatan Kra <me@yonatankra.com>
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>
YonatanKra added a commit that referenced this pull request Jul 1, 2024
@YonatanKra @RichardHelm
@rachelbt @TaylorJ76
chore(vivid): bump to v4 (#1825)
8da059a 
feat(tooltip)!: sets default max width (VIV-1799) (#1798)

* chore: updates docs

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>

* feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793)

* Make PR CI start on any main branch

* feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803)

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789)

* Improve error messages

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

---------

Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* chore(docs): v4 migration page (VIV-1801) (#1796)

* fix(tabs)!: change gutters default to small (VIV-1796) (#1804)

* chore(docs)!: refine docs for v-4 (VIV-000) (#1813)

* feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)

* attempt at RP

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>
Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com>
Co-authored-by: Yonatan Kra <me@yonatankra.com>
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>
YonatanKra added a commit that referenced this pull request Jul 1, 2024
@YonatanKra @RichardHelm
@rachelbt @TaylorJ76
Main 4.0.0 rc2 (#1826)
3574a11 
feat(tooltip): sets default max width (VIV-1799) (#1798)

* chore: updates docs

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>

feat(data-grid-cell): change default value of block-size and white-space (VIV-1797) (#1793)

* Make PR CI start on any main branch

* feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803)

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789)

* Improve error messages

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

---------

Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* chore(docs): v4 migration page (VIV-1801) (#1796)

* fix(tabs)!: change gutters default to small (VIV-1796) (#1804)

* chore(docs)!: refine docs for v-4 (VIV-000) (#1813)

* feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)

* attempt at RP

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>
Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com>
Co-authored-by: Yonatan Kra <me@yonatankra.com>
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>
YonatanKra added a commit that referenced this pull request Jul 1, 2024
@YonatanKra
chore(vivid): release vivid-4 (VIV-1795) (#1817)
06ee68a 
feat(tooltip)!: sets default max width (VIV-1799) (#1798)

feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793)

feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803)

feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789)

feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

chore(docs): v4 migration page (VIV-1801) (#1796)

fix(tabs)!: change gutters default to small (VIV-1796) (#1804)

chore(docs)!: refine docs for v-4 (VIV-000) (#1813)

feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Merged
YonatanKra added a commit that referenced this pull request Jul 4, 2024
@YonatanKra @RichardHelm
@rachelbt @TaylorJ76
Main 4.0.0 rc2 (#1836)
33afa73 
* feat(tooltip)!: sets default max width (VIV-1799) (#1798)

* chore: updates docs

* feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793)

* Make PR CI start on any main branch

* feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803)

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789)

* Improve error messages

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

* chore(docs): v4 migration page (VIV-1801) (#1796)

* fix(tabs)!: change gutters default to small (VIV-1796) (#1804)

* chore(docs)!: refine docs for v-4 (VIV-000) (#1813)

* feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)

* attempt at RP

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>
Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com>
Co-authored-by: Yonatan Kra <me@yonatankra.com>
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>
YonatanKra added a commit that referenced this pull request Jul 8, 2024
@YonatanKra @RichardHelm
@rachelbt @TaylorJ76
Main 4.0.0 rc2 (#1837)
c291e86 
* feat(tooltip)!: sets default max width (VIV-1799) (#1798)

* chore: updates docs

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>

* feat(data-grid-cell)!: change default value of block-size and white-space (VIV-1797) (#1793)

* Make PR CI start on any main branch

* feat(audio-player)!: remove css-variable for min-inline-size and max-inline-size on host (VIV-1800) (#1803)

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798) (#1789)

* Improve error messages

* feat(vue-wrappers)!: forward form values by DOM prop name (VIV-1798)

---------

Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>

* chore(docs): v4 migration page (VIV-1801) (#1796)

* fix(tabs)!: change gutters default to small (VIV-1796) (#1804)

* chore(docs)!: refine docs for v-4 (VIV-000) (#1813)

* feat(toggletip)!: add max-inline-size of 30ch & css-variable for custom size (VIV-1846) (#1814)

* attempt at RP

---------

Co-authored-by: James Taylor <jstaylor@vonht2fg32k90.home>
Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com>
Co-authored-by: Yonatan Kra <me@yonatankra.com>
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelbt rachelbt rachelbt approved these changes

Assignees
No one assigned
Labels
Breaking Change Changes that will go into the next major version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RichardHelm @rachelbt