Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audio-player): stops playing when removed from DOM (VIV-1967) #1880

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

YonatanKra
Copy link
Contributor

No description provided.

@YonatanKra YonatanKra changed the title fix(audio-player): stops playing when removed from DOM fix(audio): stops playing when removed from DOM Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (fbcf118).
Report is 1050 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1880     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       341    +218     
  Lines         1562      6210   +4648     
  Branches       108       781    +673     
===========================================
+ Hits          1562      6210   +4648     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YonatanKra YonatanKra changed the title fix(audio): stops playing when removed from DOM fix(audio-player): stops playing when removed from DOM (VIV-1967) Aug 12, 2024
@YonatanKra YonatanKra requested a review from RichardHelm August 12, 2024 20:01
@YonatanKra YonatanKra merged commit 12355d3 into main Aug 13, 2024
15 of 17 checks passed
@YonatanKra YonatanKra deleted the VIV-1967-destroy-player-after-removal-from-dom branch August 13, 2024 08:01
@github-actions github-actions bot mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants