feat(text-field): add scale attribute with condensed (VIV-1813) #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 342 +219
Lines 1562 6263 +4701
Branches 108 790 +682
===========================================
+ Hits 1562 6263 +4701
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YonatanKra
changed the title
rachelbt
reviewed
Sep 9, 2024
There was a problem hiding this comment.
added some comments.
- I'm not sure about the font size of the icon in condensed. In my suggested changes it renders as 16px.
- in other components - when the block size is 32px the border-radius is 4 px and not 8px. @AyalaBu is it true?
@YonatanKra if this need to be changed - we can do this together :)
other then that all is OK 👍
| @@ -122,6 +122,17 @@ Use the `icon` attribute to add an icon. | |||
| <vwc-text-field icon="search-line" label="Search..."></vwc-text-field> | |||
| ``` | |||
|
|
|||
| ### Scale | |||
|
|
|||
| Use the `scale` attribute to change the text field's size. | |||
There was a problem hiding this comment.
I wonder if we need to write something about not using the size property. WDYT?
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
added 2 commits
September 10, 2024 09:11
…/Vonage/vivid-3 into VIV-1813-add-textfield-condensed
|
32px the border-radius is 4 px - Correct |
YonatanKra
force-pushed
the
VIV-1813-add-textfield-condensed
branch
from
14a9eae to
883a351
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.