feat(select): add scale attribute with condensed (VIV-1836) #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1901 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 342 +219
Lines 1562 6267 +4705
Branches 108 792 +684
===========================================
+ Hits 1562 6267 +4705
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ndensed-to-select
rachelbt
reviewed
Sep 12, 2024
added 2 commits
September 16, 2024 14:36
rachelbt
reviewed
Sep 16, 2024
Comment on lines
50
to
54
| border-radius: var(#{variables.$select-control-border-radius}); | ||
| background-color: var(#{appearance.get-appearance-token(fill)}); | ||
| block-size: var(#{variables.$select-block-size}); | ||
| padding-inline: var(#{variables.$select-padding-inline}); | ||
|
|
There was a problem hiding this comment.
this needs to be inside the first &{}.
We prefer the @includes to be the first of the class.
Merged
|
I absolutely agree about the condensed option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.