feat(tab): adds closable attribute and close event (VIV-2030) #1915
Conversation
TaylorJ76
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1915 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 349 +226
Lines 1562 6773 +5211
Branches 108 869 +761
===========================================
+ Hits 1562 6773 +5211
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
didn't went over all the code yet, tested keyboad navigation and screen-reader and its not 100%.
When tab is removed (also - there's no way to know it is removable), the focus disappears, shouldn't it go the the latest tab?
Also - if all tabs are deleted it creates a strange use case:
maybe we need to add that if only one is left it can't be removed?
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
Co-authored-by: Rachel Bratt Tannenbaum <rachelbt@users.noreply.github.com>
As the removal of the tab is up to the consumer, I think handling this use case is also the consumers responsibility. I have update the examples so that when the last tab is removed, the whole tab component is also removed. And I have updated the warning note on the tab page. |
| id="close-btn" | ||
| @click="${(x, c) => x._handleCloseClick(c.event)}" | ||
| > | ||
| <${iconTag} |
There was a problem hiding this comment.
can't we use here the affix pattern as well?
No description provided.