feat(menu): add position-strategy to allow positioning menu absolute rather then fixed (VIV-2135) #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelbt
commented
Sep 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1918 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 349 +226
Lines 1562 6775 +5213
Branches 108 869 +761
===========================================
+ Hits 1562 6775 +5213
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TaylorJ76
requested changes
Sep 26, 2024
rachelbt
changed the title
TaylorJ76
previously approved these changes
Sep 30, 2024
rachelbt
changed the title
rachelbt
commented
Sep 30, 2024
There was a problem hiding this comment.
@TaylorJ76 , I changed the property to position-strategy, since placement-strategy is something else that we have in popup...
TaylorJ76
previously approved these changes
Sep 30, 2024
TaylorJ76
approved these changes
Oct 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure about the attribute name 🤔