Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add styled scrollbar (VIV-2214) #2028

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Conversation

rachelbt
Copy link
Contributor

@rachelbt rachelbt commented Nov 24, 2024

text-area width changed in chrome - due to scrollbar design - this is why the ui test has updated - the text-area is smaller in 2px

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (4e75419).
Report is 1180 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #2028     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       363    +240     
  Lines         1562      7958   +6396     
  Branches       108      1124   +1016     
===========================================
+ Hits          1562      7958   +6396     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TaylorJ76 TaylorJ76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have 1 updated snapshot? I can't see what has changed.
Otherwise all good.

Copy link
Contributor

@TaylorJ76 TaylorJ76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will the consumers add the scrollbar styles to their applications?
Will this be in a separate PR?

@rachelbt
Copy link
Contributor Author

Why do we have 1 updated snapshot? I can't see what has changed. Otherwise all good.

#2028 (comment)

@rachelbt
Copy link
Contributor Author

How will the consumers add the scrollbar styles to their applications? Will this be in a separate PR?

totally forgot about it...
Added it now to the theme.scss. I wonder if this is the right place to add it or its better to create a new file. WDTY?

@rachelbt rachelbt merged commit de5f2ee into main Nov 27, 2024
15 checks passed
@rachelbt rachelbt deleted the VIV-2214-scrollbar branch November 27, 2024 10:20
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants