-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): add styled scrollbar (VIV-2214) #2028
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 363 +240
Lines 1562 7958 +6396
Branches 108 1124 +1016
===========================================
+ Hits 1562 7958 +6396
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have 1 updated snapshot? I can't see what has changed.
Otherwise all good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will the consumers add the scrollbar styles to their applications?
Will this be in a separate PR?
|
totally forgot about it... |
text-area width changed in chrome - due to scrollbar design - this is why the ui test has updated - the text-area is smaller in 2px