Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): column basis medium and large in mobile (VIV-2049) #2065

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

rachelbt
Copy link
Contributor

@rachelbt rachelbt commented Dec 19, 2024

In both switch and action-group there's width of 380px and 250px - which makes the page behave as mobile - this is why the images updated

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (8ae0479).
Report is 1219 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #2065     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       374    +251     
  Lines         1562      9353   +7791     
  Branches       108      1504   +1396     
===========================================
+ Hits          1562      9353   +7791     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@YonatanKra YonatanKra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks :)

@TaylorJ76 TaylorJ76 merged commit 55801dc into main Jan 6, 2025
15 checks passed
@TaylorJ76 TaylorJ76 deleted the VIV-2049-layout branch January 6, 2025 09:14
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants