Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components] enable customized prefix #633

Closed
3 tasks
yinonov opened this issue Aug 28, 2022 · 1 comment · Fixed by #861
Closed
3 tasks

[Components] enable customized prefix #633

yinonov opened this issue Aug 28, 2022 · 1 comment · Fixed by #861
Labels

Comments

@yinonov
Copy link
Contributor

yinonov commented Aug 28, 2022

apps integrated within other apps may result in multiple apps within the same custom elements registry. treating different versions of vivid components in an inconsistent manner.

  • Explore the possibility for consumers to customize the custom elements prefix and enable their own scoping
    research the tradeoffs of customizing at build vs run-time.

  • we need to support css selecting custom elements (e.g. accordion selecting accordion-item). as scss has no OOTB practice to communicate with JS, we'll need to find a way to intercept scss transpilation and interpolate an agreed block to a prefix refering selector.

  • tokens should apply on enclosed scoping and not pierce in outside. that means adding a scss !default annotation to be able to change the variables applying on body selector

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Sep 28, 2022
@yinonov yinonov added Backlog and removed stale labels Sep 28, 2022
@yinonov yinonov linked a pull request Nov 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant