Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[popup] create MVP #64

Closed
yinonov opened this issue Nov 30, 2021 · 4 comments
Closed

[popup] create MVP #64

yinonov opened this issue Nov 30, 2021 · 4 comments
Assignees
Labels
Milestone

Comments

@rachelbt
Copy link
Contributor

rachelbt commented Dec 8, 2021

Summery of discussion:
we will use popper.js
or Floating UI

Basic structure:

<vwc-popup>
	<div><slot></slot></div>
</vwc-popup>
  • Hide / show
    -- Using an OPEN attribute
  • Roll - changeable roll?
  • Dismissive:
    -- Close button option - dismissible
    -- Do we use light dismissed (by clicking anywhere else)? - need to be researched
  • Position
    -- Corner(relevant to the target) & Popupcornenr (relevant to itself using transform + translate)
    -- relevant to the trigger element can be implemented in one of the following:
    --- button that trigger the popup & both need to be wrapped with div in position: relative
    --- flixed
  • Style:
    -- Looks:
    --- Plain | With tail
    --- Elevation - check with Joella
    -- Size:
    --- Inline-size
    -- Z-index issue - (should be handled as we did in side drawer or other component)

important links:
select open close issues with fixed
Discussion on: Who doesn't love some <slot/>s?

@rinaok rinaok moved this from Todo 🕓 to In Progress 🚧 in Vivid Roadmap Dec 12, 2021
@rachelbt
Copy link
Contributor

rachelbt commented Jan 16, 2022

@jshenkman:
https://tmp.dev.vivid.vonage.com/1150/index.html?path=/story/alpha-components-popup--basic
please have a look at the popup in these aspects:

  1. light theme (is the elevation OK)
  2. Alternate popup in light theme
  3. the arrow of the popup is optional.
    the content is whatever component it wraps. we added content to the story but it is only for presentation.
    The popup component is not the tooltip - its a step towards it :)
    Once the popup is UI OK we will remove it from StoryBook for it is for internal use (wrap tooltip, replace the menu surface, etc)

@jshenkman
Copy link

Everything looks great!!!! @rachelbt @rinaok nice job!!

@rinaok rinaok moved this from In Progress 🚧 to Done ✅ in Vivid Roadmap Feb 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jun 4, 2022
@yinonov yinonov closed this as completed Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants