Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(boilerplate application): side drawer template #1088

Merged
merged 227 commits into from
Oct 17, 2021
Merged

feat(boilerplate application): side drawer template #1088

merged 227 commits into from
Oct 17, 2021

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Oct 11, 2021

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

rinaok and others added 30 commits July 20, 2021 17:21
@rinaok
feat(vwc-side-drawer): 1st draft
20b9f05
@rinaok
story added
7d0d6fe
@rinaok
story added
4a0862c
@yinonov
semi-transparent content model
dabc12d
@yinonov
alternate scheme
a22dba3
@rinaok
alternate
f19388c
@rinaok
devider check
4d165af
@yinonov
working example
7f66692
@yinonov
this will break
22d7599
@yinonov
this will not break
e080a8c
@rinaok
slot="navigation"
2a5ee28
@rinaok
margin list
e80c316
@rinaok
side drawer bigger inline size
f0d12e1
@rinaok
side drawer position
2d31f37
@rinaok
appContent inlined
65cf376
@tveinfeld
Merge branch 'master' into VIV-642/feature/vwc-side-drawer
8c13aca
@tveinfeld
Merge branch 'master' into VIV-642/feature/vwc-side-drawer
cac389b
@rinaok
documentation, header, image
cf6a3c6
@rinaok
vvd-umbrella under devDependencies
e09a4c6
@rinaok
@prop
3d3ac8f
@rinaok
readme
7ff4b73
@yinonov
Update package.json
73008d3
@yinonov
Update package.json
95f4109
@yinonov
Update package.json
0eb435f
@yinonov
Update package.json
fdc05ea
@yinonov
Update package.json
f09eb4e
@rinaok
add border and shadow to side drawer
51b3c8f
@rinaok
activated
c7ed50d
@rinaok
style
d9c5bfd
@rinaok
Extension panel should not be activated
2d59c66
@rinaok rinaok marked this pull request as ready for review October 11, 2021 12:25
@rinaok rinaok requested a review from yinonov October 12, 2021 12:36
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit 29946b0 into master Oct 17, 2021
@yinonov yinonov deleted the viv-741-side-drawer-template branch October 17, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinonov yinonov yinonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rinaok @yinonov @tveinfeld @YonatanKra