Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: viv 195/iss 389 paste files file picker #401

Closed
wants to merge 9 commits into from

Conversation

gullerya
Copy link
Contributor

closes: #389

@gullerya gullerya marked this pull request as draft October 22, 2020 18:47
@github-actions
Copy link

PR showcase deployed here.

@gullerya gullerya requested a review from yinonov October 22, 2020 19:12
@gullerya
Copy link
Contributor Author

gullerya commented Oct 22, 2020

Anyone comes here to review this:

  • on the Mac paste files event
    • Safari - WORKS
    • Chrome - NOT WORKS (see this)
    • FireFox - NOT WORKS (there are tons of defects opened on paste event in their bugzilla)
  • on Windows (TBD)

@gullerya gullerya marked this pull request as ready for review October 22, 2020 20:06
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

gullerya added a commit that referenced this pull request Oct 28, 2020
@gullerya
Copy link
Contributor Author

It was decided to NOT bring this functionality at the moment, due to controversial UX benefit and poor browsers' support of paste event.

@gullerya gullerya closed this Oct 29, 2020
gullerya added a commit that referenced this pull request Oct 29, 2020
… textarea (#413)

* issue #411: initial implementation of the autofocus - textfield and textarea

* issue #411: removing async "fix"

* issue #411: implementing the tests

* issue #401: tests for area and field

* issue #411: removing the only

* issue #411: fixing the tests

* issue #411: added checkbox, slider, switch and radio to this agenda

* issue #411: added select to the agenda

* issue #411: fixing implementation of slider and checkbox

* issue #411: CR fixes
@gullerya gullerya deleted the viv-195/iss-389-paste-files-file-picker branch November 23, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

viv-195: allow the file-picker to accept paste of files
1 participant