Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vwc-icon-button-toggle): extending mwc icon-button-toggle #484

Merged
merged 12 commits into from
Dec 6, 2020

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Dec 3, 2020

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yinonov yinonov marked this pull request as draft December 3, 2020 11:46
@yinonov yinonov marked this pull request as ready for review December 3, 2020 13:14
@gullerya gullerya self-requested a review December 3, 2020 15:47
gullerya
gullerya previously approved these changes Dec 3, 2020
@gullerya
Copy link
Contributor

gullerya commented Dec 4, 2020

One comment on patch-package - just as a follow up for our conversation.
My opinion is that it is not suitable for non bleeding-edge projects and we are not those. Example of where it can't scale us: if we are patching some package and this package happens to be a dependency of a consuming application - we are patching that package for them as well - they do not expect that though...

@gullerya gullerya merged commit 05bc71c into master Dec 6, 2020
@gullerya gullerya deleted the VIV-297-vwc-icon-button-toggle branch December 6, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants