feat(dialog): add vwc-dialog #580
Conversation
# Conflicts: # tsconfig.json
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ff84424 |
|
This is the preview deployment: URL |
|
@YonatanKra can you please resolve conflicts for this to be able to merge with latest master, thanks! |
| @@ -0,0 +1,10 @@ | |||
| const fetchOriginalConfig = require('./karma.conf'); | |||
There was a problem hiding this comment.
Does it make sense to split this change (and the relevant package.json mods) into a different PR?
There was a problem hiding this comment.
Dunno - does this disturb you? Can look at it as refactor...
There was a problem hiding this comment.
Is it specific to add vwc-dialog, or does it affect other components?
There was a problem hiding this comment.
It affects nothing. Just a utility that helps me speed up development using TDD.
dont merge just yet, there are comments to attend |
# Conflicts: # tsconfig.json
Co-authored-by: yinon <yinon@hotmail.com>
That's what I've been looking for all morning! Thanks! |
Typo in component title
unnecessary syntax removed
replace integration of material by vivid in story
unnecessary syntax removed
| @use '@vonage/vvd-foundation/scss/variable-names/color-semantic-variable-names' as color-semantic; | ||
| @use '@vonage/vvd-foundation/scss/mixins/color-connotation-mixins'; | ||
|
|
||
| :host { | ||
|
|
||
| } |
There was a problem hiding this comment.
remove the file if unnecessary. it also requires a package implicitly
# Conflicts: # tsconfig.json
|
SonarCloud Quality Gate failed.
|
No description provided.