Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): add week select support #806

Merged
merged 23 commits into from
May 14, 2021
Merged

Conversation

JoelGraham93
Copy link
Contributor

Added flatpickr weekSelect plugin

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@JoelGraham93 JoelGraham93 marked this pull request as ready for review April 30, 2021 05:09
Copy link
Contributor

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jshenkman should week selection be set as range in input value? and if it's a week we select why the need for the actual date?
image

@jshenkman
Copy link
Contributor

@jshenkman should week selection be set as range in input value? and if it's a week we select why the need for the actual date?
image

I'm not 100% sure about the use case so I'll check with Tisler today.. but in general, I think the week selection might be for the viewing part - so in the calendar, you will choose to view this week but the selection is still on the day - and that's the list of events you see (in VR, for example, they have under the date picker list of event and I'm not sure if those event are for the ay or week)

@jshenkman
Copy link
Contributor

Screen Shot 2021-05-05 at 13 47 25

Just noticed this as well - if you select the last week the hover cuts of and it looks funny.. we should complete that row with the dates of the next month like we do for the previous one.

@jshenkman
Copy link
Contributor

Screen Shot 2021-05-05 at 13 47 25

Just noticed this as well - if you select the last week the hover cuts of and it looks funny.. we should complete that row with the dates of the next month like we do for the previous one.

Like this - just for the ending as well :)
Screen Shot 2021-05-05 at 13 49 43

@jshenkman
Copy link
Contributor

Screen Shot 2021-05-05 at 13 47 25 Just noticed this as well - if you select the last week the hover cuts of and it looks funny.. we should complete that row with the dates of the next month like we do for the previous one.

Like this - just for the ending as well :)
Screen Shot 2021-05-05 at 13 49 43

https://www.figma.com/file/r8OYLPmRmDqfLKt6KHdJDB/Vonage-UI-Kit-2.0?node-id=2897%3A421
Adjusted the design to have the next moth in the last row :)

@JoelGraham93
Copy link
Contributor Author

https://www.figma.com/file/r8OYLPmRmDqfLKt6KHdJDB/Vonage-UI-Kit-2.0?node-id=2897%3A421
Adjusted the design to have the next moth in the last row :)

Thanks @jshenkman, I've applied the design updates to PR

@JoelGraham93 JoelGraham93 requested a review from yinonov May 10, 2021 23:33
Copy link
Contributor

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selecting a week keeps a previously picked date (12)
image

Copy link
Contributor

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hovering over a week and stepping out keeps the week highlighted, even if another is selected already

Screen.Recording.2021-05-12.at.13.47.12.mov

@jshenkman
Copy link
Contributor

selecting a week keeps a previously picked date (12)
image

The 12 in the outlined circle is the current date, not a previous selection.

@JoelGraham93
Copy link
Contributor Author

hovering over a week and stepping out keeps the week highlighted, even if another is selected already

I'll look in to this. It's current behaviour in flatpickr but it's not nice

@JoelGraham93 JoelGraham93 requested a review from yinonov May 13, 2021 05:00
@sonarcloud
Copy link

sonarcloud bot commented May 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit a3ac951 into master May 14, 2021
@JoelGraham93 JoelGraham93 deleted the viv-515-datepicker-week branch May 16, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants