fix(toggle-button-group): reduce content mutataion in toggle button group #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revent-content-mutataion-in-toggle-button-group # Conflicts: # components/toggle-button-group/readme.md
|
🚀 Latest successful build of the PR deployed here. 🚀 |
gullerya
reviewed
May 6, 2021
| @@ -65,4 +65,4 @@ | |||
| * If you remove an item and not destroy it, remember that there’s a listener on this item | |||
| * Selected items have the `selected` | |||
| * In order to enforce styles, the following attributes are automatically removed: | |||
There was a problem hiding this comment.
probably better - "automatically applied"?
gullerya
previously approved these changes
May 6, 2021
…in-toggle-button-group
…in-toggle-button-group
|
Kudos, SonarCloud Quality Gate passed!
|
gullerya
approved these changes
May 6, 2021
YonatanKra
deleted the
VIV-536/FEATURE/prevent-content-mutataion-in-toggle-button-group
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.