Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialog): dialog dismiss button #849

Merged
merged 7 commits into from
May 20, 2021

Conversation

YonatanKra
Copy link
Contributor

No description provided.

@YonatanKra YonatanKra requested a review from gullerya May 20, 2021 07:34
@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@gullerya
Copy link
Contributor

2 remarks, which I think less important right now, so just to keep in mind:

  • the positioning via right: 16px will not play well with LTR/RTL
  • probably better way to do such an extension of the inherited MWC component is to completely replace their render, and assemble the component using their more dedicated renderers where no change needed and provide our own override where we need to extend - like here (this approach would also let you to better handle the RTL/LTR stuff)

@sonarcloud
Copy link

sonarcloud bot commented May 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@YonatanKra YonatanKra merged commit 1920c67 into master May 20, 2021
@YonatanKra YonatanKra deleted the VIV-540/feat/dialog-dismiss-button branch May 20, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants