feat(vwc-surface): viv-510 iss-859 complex menu surface #863
Conversation
gullerya
added
enhancement
|
🚀 Latest successful build of the PR deployed here. 🚀 |
gullerya
changed the title
| display: flex; | ||
| justify-content: flex-end; | ||
|
|
||
| ::slotted(vwc-button) { |
There was a problem hiding this comment.
| ::slotted(vwc-button) { | |
| ::slotted(.vwc-button + .vwc-button) { |
There was a problem hiding this comment.
I've tried several syntaxes, nothing worked to me...
| @@ -0,0 +1,23 @@ | |||
| .dropdown-content { | |||
| padding: 24px; | |||
There was a problem hiding this comment.
I suggest defining a variable as we discussed for each of the sections
:host {
--vvd-dropdown-padding-inline: 24px;
--vvd-dropdown-body-padding-inline: var(--vvd-dropdown-padding-inline); // or 0 as default?
--vvd-dropdown-actions-padding-inline: var(--vvd-dropdown-padding-inline);
}that way we have full control. what do you say?
gullerya
added
ready-to-merge
and removed
Work in Progress
components/menu/src/vwc-menu.ts
Outdated
| @@ -14,13 +16,21 @@ declare global { | |||
|
|
|||
| /* eslint-disable @typescript-eslint/ban-ts-comment */ | |||
| // @ts-ignore | |||
| MWCMenu.styles = [styleCoupling, mwcMenuStyle, vwcMenuStyle]; | |||
| MWCMenuBase.styles = [mwcMenuStyle, vwcMenuStyle]; | |||
There was a problem hiding this comment.
styles were never applied to base classes. I believe we can finally set these in our own class peacefully since we extend the base class
There was a problem hiding this comment.
Good point... I'll see if it breaks anything and will move to our own.
There was a problem hiding this comment.
Looked okay to me in StoryBook, implemented.
|
Kudos, SonarCloud Quality Gate passed!
|
closes #859
This PR prides an
vwc-surfacecomponent, which while being very similar to thevwc-menuis especially targeted to present complex contents in a surfaced fashion.