Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): new divider color api #968

Merged
merged 23 commits into from
Jul 20, 2021
Merged

Conversation

YonatanKra
Copy link
Contributor

  • --vvd-list-color-divider
  • Set sides margin to 16px
  • Vertical centering of the left icon

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2021

⚠️ No Changeset found

Latest commit: 8a1e047

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@YonatanKra YonatanKra requested a review from yinonov July 19, 2021 11:18
@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@jshenkman
Copy link
Contributor

@YonatanKra need to set sides margin to 16px also in checklist & radio list (in one-line and two-line variants)

components/list/readme.md Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit 1371016 into master Jul 20, 2021
@yinonov yinonov deleted the VIV-602/FIX/list-design-tweaks branch July 20, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants