Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken Apollo SSR #33

Closed
eric-burel opened this issue Jun 10, 2020 · 3 comments
Closed

Broken Apollo SSR #33

eric-burel opened this issue Jun 10, 2020 · 3 comments
Labels
apollo bug Something isn't working ssr

Comments

@eric-burel
Copy link
Collaborator

eric-burel commented Jun 10, 2020 •
edited
Loading

apollographql/react-apollo#3678 (comment)
vercel/next.js#9542
apollographql/react-apollo#3251

Next with Apollo allows to activate/deactivate SSR with Apollo queries

Important note

Testing SSR based on "error" state can be problematic, as getDataFromTree might just fail in error case (eg gql server non available). See a loading state in this case can be normal.
@eric-burel eric-burel added apollo bug Something isn't working ssr labels Jun 10, 2020
@eric-burel
Copy link
Collaborator Author

I've added unit tests, it seems ok with current versions.

@eric-burel
Copy link
Collaborator Author

apollographql/apollo-client#3897

@eric-burel
Copy link
Collaborator Author

apollographql/react-apollo#3918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apollo bug Something isn't working ssr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eric-burel