Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix "Eurodance Stack" aka "Enka Stack" aka Vulcan Remix #117

Open
14 of 41 tasks
eric-burel opened this issue May 6, 2022 · 0 comments
Open
14 of 41 tasks

Remix "Eurodance Stack" aka "Enka Stack" aka Vulcan Remix #117

eric-burel opened this issue May 6, 2022 · 0 comments
Labels
enhancement New feature or request remix

Comments

@eric-burel
Copy link
Collaborator

eric-burel commented May 6, 2022

🇪🇺 🐸 🛵

Vulcan Remix is a Remix stack focused on GraphQL (and a few other tools such as Storybook).

https://vulcan-remix.vercel.app/

Latest release

https://github.com/VulcanJS/eurodance-stack (edgy version)
https://github.com/VulcanJS/enka-stack (stable version)
https://github.com/VulcanJS/vulcan-remix (alias to eurodance-stack)

Roadmap

Various dev issues

Mongo and db

  • Support Mongo

GraphQL: query and mutation basics

Vulcan Fire

  • Setup Vulcan Fire Engine in the GraphQL Resource route
  • Connect to Prisma via a Vulcan connector?

GraphQL: lint, types

  • Setup type generation
  • Allow using a gql tag (= DocumentNode type) in addition to strings, check the impact on automated type generation
  • Demo generating types for a downloaded json schema (for instance when exporting from studio)

Storybook

Still have some cache issues, yarn start-storybook --no-manager-cache can help if stories are not showing up

Testing

  • Verify that fixtures can be shared between Cypress, unit tests, and storybook

Vercel

Yarn 3 workspaces

  • basic Setup in the monorepo
  • Can detect whether we are in the monorepo or not: see .vulcan/script/is-monorepo. This will be needed to handle yarn.lock correctly.
  • CI is broken. We had to remove "package-lock.json" from the starter so lerna publish works ok, yet it's required by the default github actions [Bug]: Yarn 3 support? remix-run/remix#683 (comment)
    But we don't have yarn.lock either in the starter folder, otherwise it would disable hoisting.
    Without either package-lock.json or yarn.lock the CI will fail, and it's problematic anyway.

See yarnpkg/berry#1223 (comment) for a possible solution with a plugin + postinstall script or yarnpkg/yarn#5428

Possible solutions:

  • disable the nice CI provided by the indie stack by renaming the folder to ".github.sample" and rename this folder on "init" script + reenable this CI in vulcan-npm repo instead
  • or find a way to have a "yarn.lock" in "starters/remix" without killing hoisting of local Vulcan packages (we need our remix-graphql fork)
  • CI is now running correctly.. but some jobs are failing :) need case by case investigations

Most promising solution: varsis/generate-lockfile#4

  • First, I disabled hoisting in the Remix starter package.json. This way, the "remix" binary is installed at the package level to avoid any issue: workspaces "bin" symlinks not created for sub-dependencies  yarnpkg/yarn#4964. This doesn't affect other packages or starters. This not optimal though, we'd like to find a way to hoist but keep "remix" CLI and critical deps in the right folder.
  • We have a message "Missing the "remix" package. Please run npm install remix before remix setup." on postinstall => this is probably normal at this point, since we have the same issue in raw Indie stack.
  • The "remix init" command is only run with "create-remix"! Not on "postinstall"! So you need to run it manually when cloning the monorepo => added some info in the readme, but we must double check a clean install of "vulcan-npm". I suspect remix.init folder packages are not installed automatically either, so we need first a "cd remix.init && npm installand thenyarn run remix init`.
    This init script is for instance in charge of copying ".env.example" to ".env"
  • "yarn run dev" doesn't work, because "run-p" is probably not run at the correct level. ./node_modules/.bin/run-p dev:* does work though. Same for "yarn run build". => concurrently works better and have the same features https://www.npmjs.com/package/concurrently => Remix might also update to other better maintained tools
  • Maybe I should remove this starter from Yarn workspaces, however I am afraid this would later be problematic when importing local Vulcan packages (basically Yarn will fetch them on NPM, not link them locally)? => let's be bold and keep it in the monorepo, at the moment the build works ok

Styling

  • Setup tailwind autocomplete => it seems to work out of the box actually
  • Provide basic tailwind utilities for faster startup. Tailwind is quite low level and can be frustrating for fast prototyping. A bunch of premade classNames would do the trick + autocompletion OR importing them from a package explicitely.
    Interesting, tailwind helpers bootstrap like: https://versoly.com/versoly-ui
    Another one: https://daisyui.com/

Others

  • Try running on stack blitz / code sandbox / any zero install tool => cloning on CodeSandbox Projects works pretty well. It will however open the wrong service (localhost:38XXX which is probably either a devtool or Prisma), you must open 3000 manually.

i18n

Remix has a smart way of defining the translation files you might need. useMatches let's you get some metadata for all routes and subroutes, at top level. This way, you can load translations in "root.tsx" from the metadata defined in each nested route.

@eric-burel eric-burel added enhancement New feature or request remix labels May 6, 2022
@eric-burel eric-burel pinned this issue May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request remix
Projects
None yet
Development

No branches or pull requests

1 participant