Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chlorophyll API output NA when no matching bottle metadata #36

Open
sbeaulieu opened this issue Apr 15, 2021 · 4 comments
Open

chlorophyll API output NA when no matching bottle metadata #36

sbeaulieu opened this issue Apr 15, 2021 · 4 comments
Assignees
@katemorkeski
Labels
enhancement New feature or request priority Higher priority issue to address
Milestone
chl-package-support

Comments

@sbeaulieu
Copy link
Collaborator

Output NA when no matching bottle metadata [API also will not output bucket samples bc no bottle summary.]
@ecrockford
Copy link

Assuming MVCO data eventually makes it into the API, this will be an issue because there's a significant number of bucket samples. MVCO will probably have a different approach for the API anyways but just wanted to point it out.

Also, heaven forbid we have a cruise with a broken CTD but we could encounter a cruise with numerous bucket samples where this could present a problem.

@joefutrelle joefutrelle added the enhancement New feature or request label Apr 22, 2021
@sbeaulieu
Copy link
Collaborator Author

I think similar issue for nutrient data product when lack of CTD bottle btl file, e.g., AR24A missing Casts 1 & 2, AR28B missing Cast 1

@ecrockford
Copy link

AR24A Cast 2 in chl doc actually should have been Cast 3. Fixed in NESLTERchl.xlsx today (2/11/2023). Scanned sosik log sheets have incorrect record of Cast 2 but CTD log sheet corrects to Cast 3 and CTD btl file for C3 matches log sheet depths.

@joefutrelle joefutrelle added the priority Higher priority issue to address label Mar 28, 2023
@joefutrelle joefutrelle mentioned this issue Mar 28, 2023
Open
@joefutrelle joefutrelle added this to the chl-package-support milestone Apr 3, 2023
@joefutrelle joefutrelle mentioned this issue Apr 17, 2023
Merged
@sbeaulieu
Copy link
Collaborator Author

Kate confirm bucket samples retained in current product thanks

@sbeaulieu sbeaulieu assigned katemorkeski and unassigned joefutrelle May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katemorkeski katemorkeski

Labels
enhancement New feature or request priority Higher priority issue to address
Projects
None yet
Milestone
chl-package-support
Development

No branches or pull requests
4 participants
@joefutrelle @sbeaulieu @ecrockford @katemorkeski