Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain CTD deployment comments in event log output #51

Open
sbeaulieu opened this issue Aug 9, 2022 · 4 comments
Open

retain CTD deployment comments in event log output #51

sbeaulieu opened this issue Aug 9, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@sbeaulieu
Copy link
Collaborator

comments from original elog file not provided to REST API end user in present CTD deploy workflow. example see README for ar34a events API

@joefutrelle joefutrelle changed the title consider retaining CTD deploy comments retain CTD deployment comments in event log output Feb 28, 2023
@joefutrelle
Copy link
Contributor

@sbeaulieu here's the README, can you explain how it's relevant to this issue?

2022-08-09 (_edit2 file) Removed the 2 Message ID with CTD911 other. The _edit2 file has the comments from those 2 Message ID moved into respective CTD deploy.
2022-08-09 (_edit file) Noticed there is a blank in the dateTime8601 column, Message ID 36. Filled with "Date" in appropriate format because there are no Revisions.
2019-08-20 (original file) NES-LTER Info Manager does not know why the API is not working for this elog

@sbeaulieu
Copy link
Collaborator Author

Actually we should revise this issue into 2 issues: not only to retain the comments field for events with CTD "deploy", but also to retain entire row with CTD "other" in event log output. If we retained the latter, then I would not have tried the manual _edit2 file in previous comment. The goal in both of these cases is to retain comments with regard to CTD operations that are noted into the event log.

@joefutrelle
Copy link
Contributor

We're removing CTD events and generating new deploy events from .hdr files. So we should be doing one or the other: 1) retaining CTD deploy events and their metadata, or 2) removing and regenerating CTD deploy events (the current approach).

We can't do both.

@joefutrelle
Copy link
Contributor

We have the option of not replacing the CTD deployment events.

@joefutrelle joefutrelle added the enhancement New feature or request label Mar 28, 2023
@joefutrelle joefutrelle self-assigned this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants