Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix color piracy #43

Merged
merged 5 commits into from
Nov 24, 2024
Merged

Fix color piracy #43

merged 5 commits into from
Nov 24, 2024

Conversation

jpthiele
Copy link
Contributor

This removes any use of the type pirated RGB and fixes #36

@jpthiele jpthiele requested a review from j-fu November 21, 2024 06:57
jpthiele
jpthiele commented Nov 21, 2024
View reviewed changes
src/makie.jl Outdated Show resolved Hide resolved
@jpthiele jpthiele mentioned this pull request Nov 21, 2024
Merged
@jpthiele
Copy link
Contributor Author

Notes from short in-person discussion.
We will keep the workaround with isa for now but issue a depwarn to let users know that setting a color by tuple will be removed in the next major release (whenever that may be)

@j-fu
Copy link
Member

j-fu commented Nov 21, 2024

trying to push to this pr, but somehow it doesn't work...

@j-fu j-fu merged commit bf0120a into WIAS-PDELib:main Nov 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-fu j-fu j-fu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix type piracy with Colors.RGB
2 participants
@jpthiele @j-fu