Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setState() and statechange #61

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Remove setState() and statechange #61

merged 1 commit into from
Mar 5, 2021

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Mar 5, 2021

Partially reverts some of the changes in 3eee614, which upon further consideration were deemed not so good. Closes #57.

@domenic
Remove setState() and statechange
2c5a691 
Partially reverts some of the changes in 3eee614, which upon further consideration were deemed not so good. Closes #57.
@domenic domenic mentioned this pull request Mar 5, 2021
Merged
@domenic domenic merged commit f613a56 into main Mar 5, 2021
@domenic domenic deleted the rm-setstate branch March 5, 2021 22:51
@frehner
Copy link

frehner commented Mar 7, 2021

For clarity: with this PR, does this mean that the only way to update an Entry's state is to make it the current entry (if it isn't already) and then call appHistory.update({state: newState})? Or can you do appHistory.entries[index].state = newState?

@domenic
Copy link
Collaborator Author

domenic commented Mar 8, 2021

Yeah, that's right. There is no state property anymore, just getState().

@domenic domenic mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we allow setState() separate from update()?
2 participants
@domenic @frehner