-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider supporting a list of url in attributionsrc on anchors/window.open #718
Comments
I think this would solve the documented gap from VAST: #653 |
The issue title mentions anchors and |
I think this would be a valuable addition to the API and would solve some use cases (or at least make them less awkward to handle). I think we'd probably want to be careful about how we list-ify attributionsrc. Presumably we'd want to keep the existing single URL usage consistent, but supporting say, comma-separated lists, might be less safe than it seems. I vaguely recall seeing unescaped commas in URLs in the past which could end up being problematic. Either way, supportive of this in general and +1 to supporting on As for solving the gap from #653, I'm not sure if that's right. The gap there specifically is that there is no way to register a non-navigation ping as a navigation-type registration source event. So in VAST, there is one clickthrough and potentially many click trackers, where the formers is the actual navigation on ad click and the latter are just sent as separate pings. The gap is that the latter are then interpreted as "view" type event sources, whereas they're technically recording navigation events. |
I was assuming the VAST SDK would accumulate all of the "click tracker" URLs and join like this: <a href="<VAST click through URL>" attributionsrc="<space separated VAST click trackers>">clickme</a> In this way, each click tracker would get a separate ping, and it would be classified as a click rather than a view. |
Ah, yeah, that makes sense. And I guess it would work the same way for window.open then? In which case, yes, I think that does probably mostly solve the issue. |
Yep, this issue covers |
@apasel422 pointed out that integrating a url list with window.open is not striaghtforward. Using a space separated list in the attributionsrc attribute aligns with <a> ping Because attributionsrc is included as a feature in the window.open features param, a space separated list will not work. https://html.spec.whatwg.org/multipage/nav-history-apis.html#concept-window-open-features-tokenize As the space is used as a feature token separator already in the spec. The attributionsrc feature is a url encdoded string today. A few options seem like:
@domenic for thoughts here |
I mean, stuffing all this into a string really sucks, right? I think in the ideal world, someone would work on whatwg/html#7485 first and then we'd have a clear extensibility point. I don't know if that's something you're interested in, but I hear @annevk is somewhat supportive of the idea as well, so it might be doable. Otherwise, if you're going to stick with the string syntax, a few considerations:
Between your (1) and (2) I don't have a strong preference; everything here is a mess and will hopefully be obsoleted one day by a better API. |
Following up on this. |
This would be useful for cases similar to #696, where only the first adtech knows the other reporting origins which may want to register for a specific click.
Moving these flows into a redirect chain involves changes from all reporting origins to perform a 302 redirect, rather than just the initial reporting origin making a change.
Note that today the ping attribute supports a space separated list of urls, which behaves similarly to the attributionsrc attribute in terms of sending background requests.
The text was updated successfully, but these errors were encountered: