Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is unclear how tree of tress whose root tree is not a document tree should behave. #356

Closed
hayatoito opened this issue Dec 8, 2015 · 5 comments

Comments

@hayatoito
Copy link
Contributor

After I replaced "node tree" with "component tree" in 588ecdf, I realized that it would affect the behavior of "tree of trees", in a sense before the commit, whose root tree is not a document tree.

The current spec does not say anything how such a disconnected (from a document) tree of trees should behave.

e.g.

const host = document.createElement('div');
const child = document.createElement('div');
const shadowRoot = host.attachShadow({mode: 'open'});
shadowRoot.appendChild(document.createElement('slot'));
// Note that host is not inserted into a document.
console.log(child.assignedSlot);  // What should be?

FYI. in current Blink's implementation, the distribution is correctly calculated even for such a disconnected tree of trees.

@hayatoito
Copy link
Contributor Author

I think this is a minor issue. Let me label this with v2.

@hayatoito hayatoito added the v2 label Jan 13, 2016
@annevk
Copy link
Collaborator

annevk commented Jan 14, 2016

This is something we should have defined though, no? These are all v1 features.

@rniwa
Copy link
Collaborator

rniwa commented Jan 14, 2016

Indeed. This will impact interoperability of v1 API.

@hayatoito hayatoito added v1 and removed v2 labels Jan 15, 2016
@hayatoito
Copy link
Contributor Author

I got it. Let me use v1 label for all issues which may impact interoperability.

@hayatoito
Copy link
Contributor Author

I'm going to fix the wording of the spec so that slot assigning API should work even in a such a disconnected tree of trees, whose root tree is not a document tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants