Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving instructions for generating bundle from local directory #792

Open
jan-tosovsky-cz opened this issue Aug 16, 2022 · 1 comment
Open
Labels

Comments

@jan-tosovsky-cz
Copy link

jan-tosovsky-cz commented Aug 16, 2022

Referring to instructions at https://github.com/WICG/webpackage/blob/main/go/bundle/README.md#from-a-local-directory (Usage -> From a local directory section)

Bundles are either standalone for opening in a browser as a page, or used in subresource loading with WebBundles (https://chromestatus.com/feature/5710618575241216).
The latter is accomplished by omitting the -baseURL flag. It is correctly stated this makes the bundle relative, but it is not clear it also means such a bundle can't be opened as a page (I usually prefer relative paths over absolute ones).

See related discussion here https://bugs.chromium.org/p/chromium/issues/detail?id=1352933#c3

So I propose:
The -baseURL flag is mandatory for creating standalone bundles, which can be opened in a browser. The value can be arbitrary, but keep in mind it becomes the part of the URL shown in the address bar. It has to contain the trailing slash.
Skip -baseURL for bundles used in subresource loading.

@hayatoito hayatoito added the go label Sep 27, 2022
@hayatoito
Copy link
Collaborator

Thanks for filing an issue. It seems README.md can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants