-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New sniff?] No calls to wp_title() #97
Comments
The simplest way would be to add it as a restricted function as part of #9 |
If a theme can't use the wp_title function, why have the function? |
@joyously You should be using
Like everything it was introduced when there was a need and now we have found a better way to solve the problem. The function was nearly deprecated in WP 4.4 and so that chances are high it will be deprecated in the future. |
The h1 heading is not handled by the title-tag theme_support and |
You can always use the filter |
That's not the point. There could be plugins and child themes that are filtering |
Rule type:
Error
Rule:
Check that there are no calls to
wp_title()
Ref: https://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-features
Theme check file covering this rule:
https://github.com/WordPress/theme-check/blob/master/checks/title.php
Notes for implementation:
wp_title
. This sniff should not confused the filter with a function call.To do:
The text was updated successfully, but these errors were encountered: