Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing tooltip on disabled buttons #1864

Closed
Isaacmaamouche opened this issue Jan 18, 2023 · 1 comment · Fixed by #1920 or #1921
Closed

Fix missing tooltip on disabled buttons #1864

Isaacmaamouche opened this issue Jan 18, 2023 · 1 comment · Fixed by #1920 or #1921
Assignees

Comments

@Isaacmaamouche
Copy link
Contributor

Tooltip contained in a disabled tab will not show on hover

Reproducible on welcome ui doc by adding a tooltip to a tab, and adding the disabled prop :
<Tab {...tab} disabled id="tab1"> <Tooltip content="Tab 1"> <Box>Tab 1</Box> </Tooltip> </Tab>

Sandbox exemple :

[https://codesandbox.io/p/sandbox/holy-glitter-ocgsib?file=%2Fsrc%2FApp.tsx&selection=[{"endColumn"%3A23%2C"endLineNumber"%3A26%2C"startColumn"%3A23%2C"startLineNumber"%3A26}]](https://codesandbox.io/p/sandbox/holy-glitter-ocgsib?file=%2Fsrc%2FApp.tsx&selection=%5B%7B%22endColumn%22%3A23%2C%22endLineNumber%22%3A26%2C%22startColumn%22%3A23%2C%22startLineNumber%22%3A26%7D%5D)

@Isaacmaamouche Isaacmaamouche converted this from a draft issue Jan 18, 2023
@Isaacmaamouche Isaacmaamouche changed the title Fix missing tooltip with disabled tab Fix missing tooltip on disabled buttons Jan 23, 2023
@Isaacmaamouche
Copy link
Contributor Author

Update : the problem is coming from the disabled property. It disables mouse events, which is used by the tooltip to trigger.
See the complete issue on ariakit's repo : ariakit/ariakit#471

@Isaacmaamouche Isaacmaamouche moved this from BACKLOG to TO DEV in Welcome UI - Project board Feb 7, 2023
@Isaacmaamouche Isaacmaamouche moved this from TO DEV to DEV IN PROGRESS in Welcome UI - Project board Feb 7, 2023
@Isaacmaamouche Isaacmaamouche self-assigned this Feb 7, 2023
@theo-mesnil theo-mesnil added this to the V5: foundations milestone Feb 7, 2023
@theo-mesnil theo-mesnil linked a pull request Feb 8, 2023 that will close this issue
@theo-mesnil theo-mesnil moved this from DEV IN PROGRESS to NEXT RELEASE in Welcome UI - Project board Feb 8, 2023
@theo-mesnil theo-mesnil moved this from NEXT RELEASE to RELEASED in Welcome UI - Project board Feb 8, 2023
@theo-mesnil theo-mesnil linked a pull request Feb 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2 participants