Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse byUUID query parameter as a boolean #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

honkling
Copy link

@honkling honkling commented Mar 7, 2021

Validates that ?byUUID is true or false (stringified) and parses the value as a boolean

closes #35

@jellz
Copy link
Collaborator

jellz commented Mar 7, 2021

Why can't you just check req.query.byUUID === 'true'?

routes/minecraft/players.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

byUUID breaks the search even if false
2 participants